Skip to content

feat: Add materialization support to ibis/duckdb #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyary merged 7 commits into from
May 8, 2024
Merged

feat: Add materialization support to ibis/duckdb #4173

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
74653f5
add materialization support to ibis/duckdb
tokoko May 3, 2024
9483192
remove unnecessary comments
tokoko May 3, 2024
124903c
pin ibis versions
tokoko May 3, 2024
b209d9b
refactor ibis into bunch of functions
tokoko May 3, 2024
e8ab55c
Merge pull request #2 from feast-dev/master
tokoko May 7, 2024
0edb8fb
fix requirements conflicts
tokoko May 8, 2024
dd5e8a4
Merge branch 'master' into ibis-pull-latest
tokoko May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary comments 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
@tokoko
tokoko committed May 3, 2024
commit 9483192399ba926218868e6895290c7f607b6bc7
39 changes: 0 additions & 39 deletions sdk/python/tests/integration/materialization/test_universal_materialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,43 +42,4 @@ def test_universal_materialization_consistency(environment):
# we use timestamp from generated dataframe as a split point
split_dt = df["ts_1"][4].to_pydatetime() - timedelta(seconds=1)

print(f"Split datetime: {split_dt}")

validate_offline_online_store_consistency(fs, driver_stats_fv, split_dt)


# @pytest.mark.integration
# def test_spark_materialization_consistency():
# spark_config = IntegrationTestRepoConfig(
# provider="local",
# online_store_creator=RedisOnlineStoreCreator,
# offline_store_creator=SparkDataSourceCreator,
# batch_engine={"type": "spark.engine", "partitions": 10},
# )
# spark_environment = construct_test_environment(
# spark_config, None, entity_key_serialization_version=1
# )


# driver_stats_fv = FeatureView(
# name="driver_hourly_stats",
# entities=[driver],
# ttl=timedelta(weeks=52),
# schema=[Field(name="value", dtype=Float32)],
# source=ds,
# )

# # try:
# fs.apply([driver, driver_stats_fv])

# # print(df)

# # # materialization is run in two steps and
# # # we use timestamp from generated dataframe as a split point
# # split_dt = df["ts_1"][4].to_pydatetime() - timedelta(seconds=1)

# # print(f"Split datetime: {split_dt}")

# # validate_offline_online_store_consistency(fs, driver_stats_fv, split_dt)
# # finally:
# # fs.teardown()