feat: Added support for OpenLineage integration #5884
Draft
+3,512
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
|
|
||
| ## Lineage Visualization | ||
|
|
||
| Use [Marquez](https://marquezproject.ai/) to visualize your Feast lineage: |
Member
There was a problem hiding this comment.
oh this is a weird name for openlineage's visualization but this is the name of it. leaving a comment for future
| namespace=namespace, | ||
| ) | ||
|
|
||
| return self._client.emit_dataset_event( |
Member
There was a problem hiding this comment.
why is entity a datatset event?
| namespace=namespace, | ||
| ) | ||
| except Exception as e: | ||
| logger.error(f"Error emitting historical retrieval lineage: {e}") |
Member
There was a problem hiding this comment.
we should be emitting "FAIL" events here
Member
There was a problem hiding this comment.
| logger.error(f"Error emitting historical retrieval lineage: {e}") | ||
| return False | ||
|
|
||
| def emit_online_retrieval( |
Member
There was a problem hiding this comment.
does this actually make sense to do?
| ) | ||
| } | ||
|
|
||
| result1 = self._client.emit_run_event( |
Member
There was a problem hiding this comment.
shouldn't this be an "OTHER" even type?
| ) | ||
|
|
||
| # Emit OpenLineage event for historical retrieval | ||
| self._emit_openlineage_historical_retrieval( |
Member
There was a problem hiding this comment.
do we need to emit events for retrieval?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added support for OpenLineage integration