feat: Add RBAC aggregation labels to FeatureStore ClusterRoles#6205
Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Open
feat: Add RBAC aggregation labels to FeatureStore ClusterRoles#6205ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Feast operator ships two ClusterRoles for end users (featurestore-editor-role and featurestore-viewer-role), but these roles are not automatically available to users who already have the standard Kubernetes admin, edit, or view roles in a namespace.
This means that a namespace admin who should be able to manage FeatureStore CRDs cannot do so until a cluster administrator manually creates a separate RoleBinding to one of the Feast-specific ClusterRoles. This creates an extra manual step and is inconsistent with how most operators expose their CRD permissions.
This PR adds standard Kubernetes RBAC aggregation labels to the existing FeatureStore ClusterRoles:
featurestore-editor-role:
featurestore-viewer-role:
rbac.authorization.k8s.io/aggregate-to-view: "true"These labels cause Kubernetes to automatically aggregate the permissions into the built-in admin, edit, and view ClusterRoles (Kubernetes docs)