feat: Add feature view versioning support to Redis and DynamoDB online stores#6257
Open
YassinNouh21 wants to merge 2 commits intofeast-dev:masterfrom
Open
feat: Add feature view versioning support to Redis and DynamoDB online stores#6257YassinNouh21 wants to merge 2 commits intofeast-dev:masterfrom
YassinNouh21 wants to merge 2 commits intofeast-dev:masterfrom
Conversation
…e stores Redis: Add _versioned_fv_name() helper that computes versioned feature view names (e.g. driver_stats_v2) used in hash field keys (_ts: and mmh3 feature hashes). This ensures version isolation within the same entity hash key. DynamoDB: Modify _get_table_name() to apply version suffix before template formatting, so each version gets its own DynamoDB table. Both stores are registered in _check_versioned_read_support() and the error message is updated accordingly. Closes feast-dev#6164, closes feast-dev#6163 Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_versioned_fv_name()helper that computes versioned feature view names (e.g.,driver_stats_v2) used in Redis hash field keys (_ts:prefix and mmh3 feature hashes). This ensures version isolation within the same entity hash key — the Redis key itself (entity-based) does not change, only the hash field namespace._get_table_name()to apply a version suffix before template formatting, so each version gets its own DynamoDB table (e.g.,project.driver_stats_v2)._check_versioned_read_support()and the error message inerrors.pyis updated.Changes
sdk/python/feast/infra/online_stores/redis.py_versioned_fv_name(), updatedelete_table,online_write_batch,online_read,online_read_async,_generate_hset_keys_for_featuressdk/python/feast/infra/online_stores/dynamodb.py_get_table_name()to apply version suffixsdk/python/feast/infra/online_stores/online_store.py_check_versioned_read_support()sdk/python/feast/errors.pytests/unit/.../test_redis_versioning.py_versioned_fv_name, hset key isolation, read supporttests/unit/.../test_dynamodb_versioning.py_get_table_namewith versioning, templates, read supporttests/integration/.../test_redis_versioning.pytests/integration/.../test_dynamodb_versioning.pyTest plan
test_redis_versioning.py,test_dynamodb_versioning.py)projection.version_tagcorrectly routes reads to the right versionruff checkandruff format --checkpass on all changed filesCloses #6164, closes #6163