fix: support SQL string as entity_df in RemoteOfflineStore.get_histor…#6264
Closed
korbonits wants to merge 1 commit intofeast-dev:masterfrom
Closed
fix: support SQL string as entity_df in RemoteOfflineStore.get_histor…#6264korbonits wants to merge 1 commit intofeast-dev:masterfrom
korbonits wants to merge 1 commit intofeast-dev:masterfrom
Conversation
…ical_features When entity_df is a SQL string, route it through api_parameters["entity_df_sql"] instead of calling pa.Table.from_pandas() on it (which raised AttributeError). The OfflineServer now forwards entity_df_sql from the command dict directly to the backing offline store, matching the behaviour of local stores that already support SQL entity_df. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alex Korbonits <alex@korbonits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ical_features
When entity_df is a SQL string, route it through api_parameters["entity_df_sql"] instead of calling pa.Table.from_pandas() on it (which raised AttributeError). The OfflineServer now forwards entity_df_sql from the command dict directly to the backing offline store, matching the behaviour of local stores that already support SQL entity_df.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc