Skip to content

chore: Remove dead feast loaders yaml module#6266

Merged
ntkathole merged 1 commit intofeast-dev:masterfrom
korbonits:chore/remove-dead-yaml-loader
Apr 13, 2026
Merged

chore: Remove dead feast loaders yaml module#6266
ntkathole merged 1 commit intofeast-dev:masterfrom
korbonits:chore/remove-dead-yaml-loader

Conversation

@korbonits
Copy link
Copy Markdown
Contributor

@korbonits korbonits commented Apr 11, 2026

Summary

  • yaml_loader and _get_yaml_contents in feast/loaders/yaml.py had zero callers anywhere in the codebase — confirmed via ripgrep
  • Removes the module, its __init__.py, the entire feast/loaders/ package, and the associated Sphinx .rst docs

Test plan

  • Existing unit tests pass (make test-python-unit) — no references to this module existed, so no test changes needed

🤖 Generated with Claude Code


Open with Devin

@korbonits korbonits requested a review from a team as a code owner April 11, 2026 19:07
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@korbonits korbonits changed the title chore: remove dead feast.loaders.yaml module chore: remove dead feast loaders yaml module Apr 12, 2026
@ntkathole ntkathole changed the title chore: remove dead feast loaders yaml module chore: Remove dead feast loaders yaml module Apr 13, 2026
@ntkathole
Copy link
Copy Markdown
Member

@korbonits Thanks, I noticed Sphinx docs have been falling behind as new modules were added over time, and were already out of sync. Feel free to contribute there.

yaml_loader and _get_yaml_contents had zero callers anywhere in the
codebase. Remove the module, its package, and associated Sphinx docs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Korbonits <alex@korbonits.com>
@ntkathole ntkathole force-pushed the chore/remove-dead-yaml-loader branch from 2c489f0 to ae8d6e4 Compare April 13, 2026 11:35
@ntkathole ntkathole merged commit f6b015c into feast-dev:master Apr 13, 2026
4 checks passed
@korbonits
Copy link
Copy Markdown
Contributor Author

@ntkathole -- thanks, will do!

@korbonits korbonits deleted the chore/remove-dead-yaml-loader branch April 13, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants