Skip to content

Conversation

@Iaiao
Copy link
Contributor

@Iaiao Iaiao commented Jan 20, 2022

Fix state change packet

Status

  • Ready
  • Development
  • Hold

Description

It uses f32 instead of f64. It somehow works on 1.16.5, but disconnects on 1.18.1 with message "Found 4 extra bytes in packet 30"

Related issues

#521

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

@Defman Defman merged commit b2ecc8c into feather-rs:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants