Skip to content

Fix broken Note, Important, and Warning callout syntax #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colebemis merged 1 commit into from
Mar 11, 2025
Merged

Fix broken Note, Important, and Warning callout syntax #1267

colebemis merged 1 commit into from
Mar 11, 2025

Conversation

@kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Mar 6, 2025

Spotted while reviewing the README.

Current rendering in main

image

Corrected rendering in this PR

image

@kurtmckee
Fix broken Note, Important, and Warning callout syntax
72bb300 
Spotted while reviewing the README.
@kurtmckee kurtmckee requested a review from colebemis as a code owner March 6, 2025 13:33
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 72bb300

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

colebemis
colebemis approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@colebemis colebemis merged commit 3dc050d into feathericons:main Mar 11, 2025
@kurtmckee kurtmckee deleted the fix-readme branch March 11, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis colebemis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurtmckee @colebemis