Skip to content

Decouple PageSitemap from the One Page Model. See #241.#485

Merged
matthiask merged 2 commits intofeincms:nextfrom
DrMeers:next
Nov 12, 2013
Merged

Decouple PageSitemap from the One Page Model. See #241.#485
matthiask merged 2 commits intofeincms:nextfrom
DrMeers:next

Conversation

@DrMeers
Copy link
Contributor

@DrMeers DrMeers commented Nov 11, 2013

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be from feincms import settings instead -- the FeinCMS settings aren't added to django.conf.settings. Instead, values from django.conf.settings override the default values in feincms.default_settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, thanks, I remember now. Update pushed.

@matthiask
Copy link
Member

Thanks!

matthiask added a commit that referenced this pull request Nov 12, 2013
Decouple PageSitemap from the One Page Model. See #241.
@matthiask matthiask merged commit 8b38920 into feincms:next Nov 12, 2013
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d612457 on DrMeers:next into * on feincms:next*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants