Skip to content

Make {% feincms_breadcrumbs %} isinstance check BasePage not Page. See #487 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiask merged 1 commit into from
Nov 13, 2013
Merged

Make {% feincms_breadcrumbs %} isinstance check BasePage not Page. See #487 #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions feincms/module/page/templatetags/feincms_page_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from django.conf import settings
from django.http import HttpRequest

from feincms.module.page.models import Page
from feincms.module.page.models import BasePage, Page
from feincms.utils.templatetags import (SimpleNodeWithVarAndArgs,
do_simple_node_with_var_and_args_helper,
SimpleAssignmentNodeWithVarAndArgs,
Expand Down Expand Up @@ -306,7 +306,7 @@ def feincms_breadcrumbs(page, include_self=True):
{% feincms_breadcrumbs feincms_page %}
"""

if not page or not isinstance(page, Page):
if not page or not isinstance(page, BasePage):
raise ValueError("feincms_breadcrumbs must be called with a valid Page object")

ancs = page.get_ancestors()
Expand Down