Fix blocking of actix thread in case it's streaming arrow over http. #4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Jun 27, 2025
| futures::executor::block_on(self.tx.send(bytes)).unwrap(); | ||
| let tx = self.tx.clone(); | ||
| let handle = TOKIO.spawn(async move { tx.send(bytes).await }); | ||
| self.handles.push(handle); |
Contributor
There was a problem hiding this comment.
this looks like magic. is Drop getting rid of some stuff?
Contributor
Author
There was a problem hiding this comment.
No see flush implementation below, it's not used yet but the right way would be to wait on all the handles. I'll make an issue about this in arrow-rs
mihaibudiu
approved these changes
Jun 27, 2025
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4239