Skip to content

[WebConsole] Add a Bun version check to prevent building with unsupported version #5237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Karakatiza666 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WebConsole] Add a Bun version check to prevent building with unsupported version #5237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions js-packages/web-console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@
"private": true,
"scripts": {
"clean-install": "bun ci",
"dev": "vite dev --host",
"check-bun-version": "bun run scripts/check-bun-version.ts",
"dev": "bun run check-bun-version && vite dev --host",
"prebuild": "cd ../profiler-lib && bun run build",
"build": "svelte-kit sync && svelte-check --threshold error && vite build",
"build": "bun run check-bun-version && svelte-kit sync && svelte-check --threshold error && vite build",
"preview": "vite preview --host",
"check": "svelte-kit sync && svelte-check",
"check:watch": "svelte-kit sync && svelte-check --watch",
Expand Down
31 changes: 31 additions & 0 deletions js-packages/web-console/scripts/check-bun-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { $ } from 'bun'
import semver from 'semver'

const MIN_BUN_VERSION = '1.3.3'

async function checkBunVersion() {
try {
// Get current Bun version
const result = await $`bun --version`.text()
const currentVersion = result.trim()

console.log(`Current Bun version: ${currentVersion}`)
console.log(`Required minimum version: ${MIN_BUN_VERSION}`)

// Compare versions
if (!semver.gte(currentVersion, MIN_BUN_VERSION)) {
console.error(
`\n❌ Error: Bun version ${currentVersion} is too old. Please upgrade to ${MIN_BUN_VERSION} or higher.`
)
console.error(` Run: bun upgrade`)
process.exit(1)
}

console.log(`✓ Bun version check passed\n`)
} catch (error) {
console.error('Failed to check Bun version:', error)
process.exit(1)
}
}

checkBunVersion()
2 changes: 1 addition & 1 deletion js-packages/web-console/src/lib/compositions/usePipelineManager.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const usePipelineManager = (options?: FetchOptions) => {
// ...(await getAuthorizationHeaders()),
// Accept: 'application/zip'
// }
const fileName = `fda-bundle-${pipelineName}-${new Date().toISOString().replace(/\.\d{3}/, '')}.zip`
const fileName = `feldera-support-bundle-${pipelineName}-${new Date().toISOString().replace(/\.\d{3}/, '')}.zip`
// // Use simple fetch approach (loads into memory) instead of streaming
triggerFileDownload(fileName, blob)
}
Expand Down