Skip to content

[sql-compiler] Implement percentile_cont and percetile_disc aggregate functions #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Karakatiza666 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[sql-compiler] Implement percentile_cont and percetile_disc aggregate functions #5470

Karakatiza666 wants to merge 3 commits into from
+5,323 −75

Conversation

@Karakatiza666
Copy link
Contributor

@Karakatiza666 Karakatiza666 commented Jan 20, 2026

No description provided.

@Karakatiza666
Copy link
Contributor Author

Karakatiza666 commented Jan 20, 2026

@copilot finish the implementation of percentile_cont and percetile_disc. Note that Calcite already supports these. See other implementations for aggregate functions as a reference point. To start, run the current regression test with: mvn test -Dtest=RegressionTests#issue3778, analyze and fix the error

Copilot AI mentioned this pull request Jan 20, 2026
Merged
Copy link
Contributor

Copilot AI commented Jan 20, 2026

@Karakatiza666 I've opened a new pull request, #5471, to work on those changes. Once the pull request is ready, I'll request review from you.

@mihaibudiu
Copy link
Contributor

mihaibudiu commented Jan 20, 2026

The brute-force solution is actually not particularly difficult; just use ARRAY_AGG and run PERCENTILE for the arrays. But ARRAY_AGG is the worst possible aggregate function in terms of performance: https://docs.feldera.com/sql/aggregates/#efficient-aggregation-functions

@ryzhyk
Copy link
Contributor

ryzhyk commented Jan 21, 2026

This data structure looks like a group. This aggregate may be quasi-linear, similar to Avg.

tree: BTreeMap<T, i64>,

@Karakatiza666
[sql-compiler] Implement percentile_cont and percetile_disc aggregate…
cff0a77 
… functions

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
@Karakatiza666
[dbsp] Re-implement OrderStatisticsMultiset for O(log(n)) complexity …
4030c72 
…for insert, update, select and rank

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
@feldera-bot
[ci] apply automatic fixes
d14b3b3 
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Karakatiza666 @mihaibudiu @ryzhyk @feldera-bot