[datagen] fix binary generation #5480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we would generate i8 in this case but our code expects u8. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in binary data generation where the minimum value for u8 elements was incorrectly using i8::MIN (-128) instead of u8::MIN (0).
Changes:
- Added conditional logic to set the minimum value to u8::MIN when the
scalefield is set, matching the existing pattern for maximum value handling
mihaibudiu
reviewed
Jan 20, 2026
Contributor
mihaibudiu
left a comment
There was a problem hiding this comment.
binary?
this is in generate_integer.
Also, why MIN when scale is defined?
Contributor
Author
|
we use it to generate binary too, we set scale to indicate it's a u8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we would generate i8 in this case but our code expects u8.