[SQL] Insert correct operator in circuit when compiling MINUS #5482
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an operator insertion bug in the SQL→DBSP compilation of MINUS by ensuring the negation operator is added to the circuit before downstream casting, and adds regression coverage for MINUS / MINUS ALL.
Changes:
- Fix
visitMinusoperator construction order soDBSPNegateOperatoris added beforecastOutput(...)can wrap it. - Add regression tests compiling
MINUSandMINUS ALLcases that previously lacked coverage.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/compiler/frontend/CalciteToDBSPCompiler.java |
Ensures the negate operator is inserted into the circuit before being used as an input to a generated cast/map operator during MINUS compilation. |
sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/simple/Regression2Tests.java |
Adds regression tests that compile MINUS / MINUS ALL, covering cases not previously exercised by tests. |
2e024fd to
0214a45
Compare
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
rivudhk
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5479
The implementation of EXCEPT ALL or INTERSECTION ALL is incorrect, so I just documented these as unimplemented until we fix this problem.