Skip to content

Conversation

@prehner
Copy link
Contributor

@prehner prehner commented Nov 30, 2023

This adds Identifier, IdentifierOption, PureRecord, and SegmentRecord to feos.ideal_gas.

In the short term this allows to handle ideal gas parameters like other models. For the future, there remain 3 issues:

  1. In Python, we have a PureRecord for every model, which can lead to confusing errors or the requirement to rename imports.
  2. The PureRecord in feos.ideal_gas refers to Joback specifically, so if we add more models, the naming will be awkward.
  3. It might be more clear if non-generic Python classes (Identifier and IdentifierOption) are exported only once.

@prehner prehner requested a review from g-bauer November 30, 2023 09:24
@prehner prehner merged commit 87272c3 into main Nov 30, 2023
@prehner prehner deleted the pure_record_joback branch November 30, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants