Skip to content

Conversation

@g-bauer
Copy link
Contributor

@g-bauer g-bauer commented Feb 14, 2024

This PR restructures some elements of feos-core that make the code easier and a bit less opinionated.

  • Removal of the methods that return trait objects from Residual and IdealGas: the interface for the Helmholtz energy calculation no longer distinguishes between different contributions.
  • Consequently, we get rid of the traits and constructs to create object-safe traits.
  • Since the interface for the Helmholtz energy is less rigid we can think about efficiently calculating properties that are used across different contributions or even caching.

@prehner prehner marked this pull request as ready for review February 22, 2024 07:52
@g-bauer g-bauer merged commit 150568d into main Feb 26, 2024
@g-bauer g-bauer deleted the restructure_core branch February 26, 2024 12:14
@prehner prehner added this to the v0.7.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants