Make FirebasePerformance initialization lazy.#2518
Merged
jeremyjiang-dev merged 8 commits intomasterfrom Mar 25, 2021
Merged
Conversation
Collaborator
Coverage ReportAffected SDKsNo changes between base commit (0b61832) and head commit (3bcdb287). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (3bcdb287) is created by Prow via merging commits: 0b61832 c0ddadb. |
Collaborator
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (3bcdb287) is created by Prow via merging commits: 0b61832 c0ddadb. |
vkryachko
reviewed
Mar 23, 2021
firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java
Show resolved
Hide resolved
Collaborator
|
The public api surface has changed for the subproject firebase-perf: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Contributor
Author
|
/test check-changed |
visumickey
reviewed
Mar 24, 2021
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/test/java/com/google/firebase/perf/application/AppStateMonitorTest.java
Show resolved
Hide resolved
ramanpreetSinghKhinda
approved these changes
Mar 24, 2021
firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
Show resolved
Hide resolved
Contributor
Author
|
/test check-changed |
1 similar comment
Contributor
Author
|
/test check-changed |
visumickey
approved these changes
Mar 25, 2021
firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onActivityResumed()callback. Based on our definition of app startup time, initializing FirebasePerformance afteronActivityResume()will not be included in the app startup time. Traces generated before FirebasePerformance initialization will be added to the pendingpendingEventsQueueand will be dispatched whenFirebasePerformanceis available.