fix: eager exiting to prevent hung state#1090
fix: eager exiting to prevent hung state#1090laggingreflex wants to merge 1 commit intofluent-ffmpeg:masterfrom
Conversation
|
It seems that fluent-ffmpeg is no longer maintained, but I'd be curious to understand what causes the issue. I couldn't replicate it, unfortunately (even on Windows 10). What I thought initially was a possible deadlock with the |
|
@federicocarboni Thanks for the reply! I haven't found the root cause. Another solution (than this fix) that works for me is if I use a retry function (with a timeout). I've been using ffmpeg and this library in a project for a long time and this has only occurred on a particular setup - a large set of video files (150k files, 2.7TB) on a USB HDD. I should add that there were also bad sectors on this HDD that I repaired (chkdsk) earlier. My project involves ffprobe-ing a lot of those files and a lot of them have been failing seemingly randomly. I'm suspecting this whole particular setup (the HDD and/or act of probing a lot of files) might have something to do with it. Since I can't even seem to reproduce the issue on same files that failed when I try again. PS: I tried your library (eloquent-ffmpeg) as well - same issue (fails randomly, works on retrying). |
|
@laggingreflex CI tests seem to be failing because mocha was updated and it no longer supports Node.js 8, which is a test target for this project. |
It doesn't. Just "data" event. Here's what (it's after a 5000ms timeout)
Definitely. Please feel free to give any other debugging pointers, I'll try them out. Or I'll update if I come across anything more useful. |
Possible fix for #1089. I know it's a hacky solution, so not exactly hoping to get merged, but just to show where the problem exists.
It parses the data (
on(data)) and exists eagerly without having to wait for the exit event - which is what's causing #1089fixes #1089