Skip to content

Update dependencies and update nodejs version#146

Merged
liquidnya merged 11 commits intodevelopfrom
feature/node22
Nov 17, 2025
Merged

Update dependencies and update nodejs version#146
liquidnya merged 11 commits intodevelopfrom
feature/node22

Conversation

@liquidnya
Copy link
Contributor

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you run npm run check on the code and resolved any errors?
  • Have you run npm test and all tests are passing?
  • Have you added new tests for any new functions created?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated CHANGELOG.md to add your changed under the [Unreleased] heading?

Description

This PR upgrades to node version 22.12.0 which is the latest LTS node version as of the creation of this PR.

All dependencies are also upgraded to the newest versions.

There were 2 changes to our code base, because upgrading dependencies required those changes:

  • The uuid.v4 function no longer internally uses an array, but instead uses Uint8Array. This only affects tests.
  • With a new eslint/typescript version a function call was detected to be unsound. See https://typescript-eslint.io/rules/no-unsafe-call/. The fix was to opt into that unsound function call. The linter no longer fails and the runtime code should be exactly the same as before.

This PR uses the ~ prefix for some dependency versions now:

  • @eslint/js
  • eslint
  • eslint-plugin-jest
  • eslint-plugin-prettier
  • prettier
  • typescript
  • typescript-eslint

This is because minor versions of typescript or eslint often introduces new linter errors.
prettier is added to that list - not because it is expected to break on minor releases, but - because eslint-plugin-prettier might break with a new minor version.

Benefits

Up to date and no known security vulnerabilities.

Closes #145.
Closes #131.

Potential drawbacks

Maybe something could break.

@liquidnya liquidnya requested a review from demize December 22, 2024 14:18
@liquidnya
Copy link
Contributor Author

Updated the workflow to test with nodejs 22 and 23.

@liquidnya
Copy link
Contributor Author

Merged main into this branch.

Copy link
Contributor

@demize demize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test currently, but CI passes and the changes are minimal. LGTM.

Unfortunately the Docker tests won't run since we seem to have been booted from the DSOS program, but oh well...

@demize
Copy link
Contributor

demize commented Dec 26, 2024

Might need to disable the merge queue temporarily to force the merge through; might as well leave it disabled while you’re at it…

@liquidnya
Copy link
Contributor Author

I don't remember what that force push was about. I might have force pushed the wrong branch.
I will force push 81ba580 onto this branch again, since that was the commit that got approched and then merge.

@liquidnya
Copy link
Contributor Author

I used the merge on Github to merge develop into this branch automatically before merging this into develop.

@liquidnya liquidnya enabled auto-merge November 17, 2025 19:15
@liquidnya liquidnya disabled auto-merge November 17, 2025 19:15
@liquidnya liquidnya enabled auto-merge November 17, 2025 19:29
@liquidnya liquidnya added this pull request to the merge queue Nov 17, 2025
@liquidnya
Copy link
Contributor Author

I removed the requirement of having all tests run for NodeJS 20.x and 21.x, since I could not merge and the new Version requires 22.x!

Merged via the queue into develop with commit 9d76d29 Nov 17, 2025
4 checks passed
@liquidnya liquidnya deleted the feature/node22 branch November 17, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants