feat: add edit note feature #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Let me know if something is not ok. PS: forgive the "text" of the first note in the video, I'm tired and didn't know what I was writing either 😎 |
Closed
Contributor
Author
|
Commenting to bring attention to this... |
|
+1 |
adamperrry
approved these changes
Aug 24, 2023
Contributor
adamperrry
left a comment
There was a problem hiding this comment.
This looks really great, you did an awesome job matching the icon style too 😄 I'm going to approve and merge it in, and I'll start the process for cutting a release, testing it internally, and publishing.
Thanks for taking the time to make the add-on better!
Contributor
Author
|
Great! I enjoyed adding this 😎 Let me know if you need to... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would close #1
Added "Edit" note feature.
Refactored a bit of the "state" logic of
Notes.jsxto handle the new feature.Added Pencil icon.
Kapture.2023-06-06.at.02.46.34.mp4