Open
Conversation
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 14 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 61.43% 83.13% +21.7%
==========================================
Files 789 2 -787
Lines 43247 83 -43164
Branches 8375 57 -8318
==========================================
+ Hits 26575 69 -26506
- Misses 16672 14 -16658
- Partials 82 8 -74Generated by Codecov Action |
1 similar comment
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 14 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 61.43% 83.13% +21.7%
==========================================
Files 789 2 -787
Lines 43247 83 -43164
Branches 8375 57 -8318
==========================================
+ Hits 26575 69 -26506
- Misses 16672 14 -16658
- Partials 82 8 -74Generated by Codecov Action |
Member
Author
|
This seems to be jumping all over the plance: +20% on this PR? I don't think so 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check
started failing in CI recently. While we can still merge stuff despite the fail, it blocks releases as I learned the hard way in
10.39.0-alpha.0. This job is not in our repo's config but added via the Codecov app. It is configured via thecodecov.ymlfile in our repo. This PR switches off the project coverage check, since it seems to be flawed at the moment.Already talked to @MathurAditya724 who will take another look at the action. Once fixed, we can revert this PR.