Open
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
0926993 to
101e9f9
Compare
isaacs
added a commit
that referenced
this pull request
Feb 23, 2026
- Updated `minimatch` direct dependency in our packages (packages/node, packages/react-router, and packages/remix) - Added some yarn resolutions for old pinned versions of minimatch that are unlikely to be updated in their respective dependencies. fixes JS-1765 fixes #19431
101e9f9 to
43842b9
Compare
isaacs
added a commit
that referenced
this pull request
Feb 23, 2026
- Updated `minimatch` direct dependency in our packages (packages/node, packages/react-router, and packages/remix) - Added some yarn resolutions for old pinned versions of minimatch that are unlikely to be updated in their respective dependencies. fixes JS-1765 fixes #19431
43842b9 to
c13f91c
Compare
Member
Author
|
Dependency review CI is still catching up. The minimatch versions it's flagging all have the fix for the CVE, just waiting on it to go through the GH advisory workflow. The license for glob and rimraf are BlueOak-1.0.0, which was just recently approved in our fossa instance. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
isaacs
added a commit
that referenced
this pull request
Feb 24, 2026
- Updated `minimatch` direct dependency in our packages (packages/node, packages/react-router, and packages/remix) - Added some yarn resolutions for old pinned versions of minimatch that are unlikely to be updated in their respective dependencies. fixes JS-1765 fixes #19431
c13f91c to
944ed68
Compare
- Updated `minimatch` direct dependency in our packages (packages/node, packages/react-router, and packages/remix) - Added some yarn resolutions for old pinned versions of minimatch that are unlikely to be updated in their respective dependencies. fixes JS-1765 fixes #19431
944ed68 to
acbd011
Compare
Comment on lines
72
to
78
| "@sentry/core": "10.40.0", | ||
| "@sentry/node": "10.40.0", | ||
| "@sentry/react": "10.40.0", | ||
| "glob": "^10.3.4", | ||
| "glob": "^13.0.6", | ||
| "yargs": "^17.6.0" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Bug: The update to glob v13 removes the glob.sync() and glob.glob() APIs, which are still used by multiple build and test scripts, causing them to fail at runtime.
Severity: HIGH
Suggested Fix
Update all usages of the deprecated glob APIs. Replace const mapFiles = glob.sync(...) with import { globSync } from 'glob'; const mapFiles = globSync(...). Similarly, refactor any callback-based glob.glob() calls to use the modern promise-based or synchronous APIs provided by glob v13.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/remix/package.json#L72-L78
Potential issue: The pull request updates the `glob` dependency to version 13. This
major version update removes the `glob.sync()` method and the callback-based
`glob.glob()` function, which are used in several build and test scripts across the
repository. For example, the `deleteSourcemaps.js` script, which is part of the Remix
package's build process, uses `glob.sync()`. When this script is executed with the
updated dependency, it will throw a `TypeError: glob.sync is not a function`, causing
the build process to fail. Other scripts in `dev-packages` will also fail for the same
reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimatchdirect dependency packages/node, packages/react-router, and packages/remix@sentry/bundler-plugin-coreThere are several other dependencies that transitively bring in a minimatch v3, v5, v8, or v9. Fixes for the ReDOS will be backported where those dependencies cannot be easily updated.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Closes #issue_link_here