chore(triage-action): Fix JSON parsing#19471
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| elif isinstance(obj, list): | ||
| for item in obj: | ||
| if isinstance(item, dict) and item.get("type") == "result": | ||
| results.append(item) |
There was a problem hiding this comment.
No regression test added
Low Severity
This change fixes JSON parsing in write_job_summary.py, but the PR doesn’t add any unit/integration coverage to prevent regressions (e.g., a pretty-printed JSON array file and an NDJSON file). This was flagged because the review guidelines call out adding tests for fix PRs.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Contributor
size-limit report 📦
|
chargome
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is a single pretty-printed JSON array,
JSON.stringify(messages, null, 2)(source code), not NDJSON. This script change (treating the parsed root as a list and collecting objects with type === "result") reads it correctly.This is the the current error output:
Closes #19472 (added automatically)