feat(core,cloudflare): Add dispose to the client for proper cleanup#19506
Draft
feat(core,cloudflare): Add dispose to the client for proper cleanup#19506
Conversation
cec1807 to
3545d37
Compare
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19475
closes JS-1785
This is a way to dispose the client entirely. Every request in Cloudflare Workers create their own client. Once the request is done the client would stay in memory forever, unless we
disposeit after every request. We also have to wait until allwaitUntils are finished, otherwise we would loose these traces.The
dispose()method got added on purpose into the core client, as thegetCurrentClient()would return aClient. Thedispose()method actually only has functionality inside theServerRuntimeClient, as only the server would need this functionality.There is still a leak in one of the default integrations, but when running load tests against the reproduction repo and setting
defaultIntegrations: false, then no leak is happening.FWIW there will be a separate PR for adding a MemoryProfiler as seen in #19364, to prevent this memory leak in the future.