feat(litestar): Add failed_request_status_codes#4021
Merged
sentrivana merged 5 commits intogetsentry:masterfrom Feb 6, 2025
vrslev:litestar-failed-request-status-codes
Merged
feat(litestar): Add failed_request_status_codes#4021sentrivana merged 5 commits intogetsentry:masterfrom vrslev:litestar-failed-request-status-codes
failed_request_status_codes#4021sentrivana merged 5 commits intogetsentry:masterfrom
vrslev:litestar-failed-request-status-codes
Conversation
6 tasks
failed_request_status_codes
Contributor
|
Hey @vrslev, thank you for this PR! Code-wise looks great to me, I'll take it for a spin and prepare the docs for the change and then we should be ready to go. No action needed from your side, I'll ping you if that changes. Thanks again! |
12 tasks
Contributor
Author
|
@sentrivana that's great! I've prepared docs myself already :) |
Contributor
|
Awesome! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4021 +/- ##
==========================================
+ Coverage 80.21% 80.23% +0.01%
==========================================
Files 139 139
Lines 15403 15411 +8
Branches 2601 2603 +2
==========================================
+ Hits 12356 12365 +9
- Misses 2203 2209 +6
+ Partials 844 837 -7
|
sentrivana
approved these changes
Feb 6, 2025
sentrivana
pushed a commit
that referenced
this pull request
Jun 25, 2025
…ed in middleware (#4074) This is a fix for #4021: exceptions raised in middleware were sent without taking into account `failed_request_status_codes` value. See the test case for an example. --------- Co-authored-by: Anton Pirker <anton.pirker@sentry.io> Co-authored-by: Daniel Szoke <daniel.szoke@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3134
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.