ref(openai): Separate output handling#5543
Open
alexander-alderman-webb wants to merge 3 commits intomasterfrom
Open
ref(openai): Separate output handling#5543alexander-alderman-webb wants to merge 3 commits intomasterfrom
alexander-alderman-webb wants to merge 3 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧Agents
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 31 passed | Total: 31 | Pass Rate: 100% | Execution Time: 12.97s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 30.00%. Project has 14375 uncovered lines. Files with missing lines (181)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 26.45% 27.57% +1.12%
==========================================
Files 189 189 —
Lines 19830 19846 +16
Branches 6428 6432 +4
==========================================
+ Hits 5246 5471 +225
- Misses 14584 14375 -209
- Partials 457 488 +31Generated by Codecov Action |
ericapisani
approved these changes
Feb 26, 2026
Member
ericapisani
left a comment
There was a problem hiding this comment.
Couple of naming things but otherwise LGTM.
| kwargs: "dict[str, Any]", | ||
| integration: "OpenAIIntegration", | ||
| start_time: "Optional[float]" = None, | ||
| finish_span: bool = True, |
Member
There was a problem hiding this comment.
Nit: I can see there being a possibility that the name finish_span could be interpreted as the "ending span" (a noun) rather than "mark the span as finished" (a verb/action).
If it's not a massive pain, it might be worth renaming to mark_span_as_finished
|
|
||
|
|
||
| def _set_output_data( | ||
| def _common_set_output_data( |
Member
There was a problem hiding this comment.
Nit: _set_common_output_data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create separate functions for output-handling of
openaiResponses, Completions, and Embedding API functions. Create streaming variants where applicable.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)