fix(openai): Attach response model with streamed Completions API#5557
Open
alexander-alderman-webb wants to merge 4 commits intowebb/openai/add-response-modelfrom
Open
fix(openai): Attach response model with streamed Completions API#5557alexander-alderman-webb wants to merge 4 commits intowebb/openai/add-response-modelfrom
alexander-alderman-webb wants to merge 4 commits intowebb/openai/add-response-modelfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧Agents
Openai
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 53 passed | Total: 53 | Pass Rate: 100% | Execution Time: 15.90s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14416 uncovered lines. Files with missing lines (178)
Generated by Codecov Action |
…sponse-model-completions
| nonlocal ttft | ||
| count_tokens_manually = True | ||
| for x in old_iterator: | ||
| span.set_data(SPANDATA.GEN_AI_RESPONSE_MODEL, x.model) |
There was a problem hiding this comment.
Ungarded streamed model access can raise
Medium Severity
x.model is read directly in the streaming iterators before capture_internal_exceptions(). If a streamed chunk does not expose model (or uses a dict-like/event variant), this raises and interrupts iteration, making instrumentation break the caller’s stream instead of failing safely.
Additional Locations (1)
Contributor
Author
There was a problem hiding this comment.
Spec says it's required: developers.openai.com/api/reference/resources/chat/subresources/completions/streaming-events
ericapisani
approved these changes
Feb 26, 2026
…sponse-model-completions
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…sponse-model-completions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)