Go: Fix bug in ResponseWriter for variadic MaD#16619
Merged
owen-mc merged 1 commit intogithub:mainfrom Jun 4, 2024
Merged
Conversation
`getSummaryInputOrOutputNode` was giving the summary component stack for arguments corresponding to variadic parameters. This will be a problem when the models for variadic functions are converted to models-as-data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSummaryInputOrOutputNodewas giving the summary component stack for arguments corresponding to variadic parameters. This will be a problem when the models for variadic functions are converted to models-as-data.Note: this has no tests, but it has been extracted from #16592 where it was needed to fix some tests that failed after some models were converted to models-as-data. So I feel this is okay, as it will be tested by that PR.