Actions: Add taint summary for suisei-cn/actions-download-file url input#21600
Open
XinyuZhangXvX wants to merge 2 commits intogithub:mainfrom
Open
Actions: Add taint summary for suisei-cn/actions-download-file url input#21600XinyuZhangXvX wants to merge 2 commits intogithub:mainfrom
XinyuZhangXvX wants to merge 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Actions taint-flow summary to improve CodeQL’s GitHub Actions modeling coverage for suisei-cn/actions-download-file, ensuring the url input is recognized as influencing the filename output (in addition to the already-modeled filename input).
Changes:
- Add a new
actionsSummaryModeltaint summary mappinginput.url→output.filenameforsuisei-cn/actions-download-file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input.urltooutput.filenameforsuisei-cn/actions-download-fileinput.filename→output.filename; this adds coverage for theurlinput, which can also influence the downloaded filenameData flow analysis
Reference: https://github.com/suisei-cn/actions-download-file/blob/master/index.js
input.url→output.filename:text = core.getInput("url")reads theurlinputurlis derived fromtextfilenameinput is not provided,finalFilename = getFilenameFromUrl(url)extracts the filename from the URL pathcore.setOutput("filename", finalFilename)writes to thefilenameoutputinput.filename→output.filename(existing):filename = core.getInput("filename")reads thefilenameinputfinalFilename = filename ? String(filename) : getFilenameFromUrl(url)takes thefilenamevalue directlycore.setOutput("filename", finalFilename)writes to thefilenameoutput