Skip to content

Actions: Removed a false positive injection sink model for theveracode/veracode-sca action. #21604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XinyuZhangXvX wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Actions: Removed a false positive injection sink model for theveracode/veracode-sca action. #21604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion actions/ql/lib/ext/manual/veracode_veracode-sca.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ extensions:
data:
- ["veracode/veracode-sca", "*", "input.url", "command-injection", "manual"]
- ["veracode/veracode-sca", "*", "input.path", "command-injection", "manual"]
- ["veracode/veracode-sca", "*", "input.skip-collectors", "command-injection", "manual"]
- ["veracode/veracode-sca", "*", "input.url", "command-injection", "manual"]
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actionsSinkModel data contains the input.url command-injection entry twice. This can lead to duplicate modeled sinks (and potentially duplicated results) and makes the model harder to maintain. Remove the duplicate row or replace it with the intended distinct input/kind if this was meant to cover something else.

Suggested change
- ["veracode/veracode-sca", "*", "input.url", "command-injection", "manual"]

Copilot uses AI. Check for mistakes.
4 changes: 4 additions & 0 deletions actions/ql/src/change-notes/2026-03-27-veracode#veracode-sca.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Removed false positive injection sink models for the `skip-collectors` input of `veracode/veracode-sca`.
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change note says "sink models" (plural), but this PR removes a single sink model entry (input.skip-collectors). Consider making this singular to keep the release note accurate.

Suggested change
* Removed false positive injection sink models for the `skip-collectors` input of `veracode/veracode-sca`.
* Removed a false positive injection sink model for the `skip-collectors` input of `veracode/veracode-sca`.

Copilot uses AI. Check for mistakes.
Loading