Add extra source to actions CWE-094/CodeInjectionMedium#21672
Open
knewbury01 wants to merge 1 commit intogithub:mainfrom
Open
Add extra source to actions CWE-094/CodeInjectionMedium#21672knewbury01 wants to merge 1 commit intogithub:mainfrom
knewbury01 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the actions/code-injection/medium query’s behavior with existing context-event source handling by also treating github.head_ref as a source on pull_request, reducing reporting inconsistencies between equivalent GitHub context expressions.
Changes:
- Added a new
RemoteFlowSourcein the medium code injection query to modelgithub.head_reffor thepull_requestevent. - Added a change note documenting the expected increase in results for
actions/code-injection/medium.
Show a summary per file
| File | Description |
|---|---|
| actions/ql/src/Security/CWE-094/CodeInjectionMedium.ql | Introduces a new GitHub-context-based source specific to the medium query. |
| actions/ql/src/change-notes/2026-04-08-codeinjection-medium-sources.md | Documents the new source behavior and the resulting increase in findings. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Comment on lines
+22
to
+26
| * A data flow source of user input from github context. | ||
| * eg: github.head_ref | ||
| * Usually only considered for pull_request_target where access to secrets | ||
| * and tokens is more available. | ||
| * However this query already finds all context events as sources regardless |
There was a problem hiding this comment.
The new doc comment has a few wording/capitalization issues: "github" should be capitalized as "GitHub", and "eg" should be "e.g.". Consider also backticking event/context identifiers (for example github.head_ref, pull_request_target) to improve readability.
Suggested change
| * A data flow source of user input from github context. | |
| * eg: github.head_ref | |
| * Usually only considered for pull_request_target where access to secrets | |
| * and tokens is more available. | |
| * However this query already finds all context events as sources regardless | |
| * A data flow source of user input from GitHub context. | |
| * e.g.: `github.head_ref` | |
| * Usually only considered for `pull_request_target` where access to secrets | |
| * and tokens is more available. | |
| * However this query already finds all context events as sources regardless, |
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Added source type to `actions/code-injection/medium` such that now `github.head_ref` is found as source even on event `pull_request` (not just `pull_request_target`). This will result in the query finding more results. No newline at end of file |
There was a problem hiding this comment.
The change note sentence is a bit ungrammatical/awkward ("such that now", "found as source", "on event"). Consider rephrasing to something like "...so github.head_ref is now treated as a source on the pull_request event (not just pull_request_target)" for clarity.
Suggested change
| * Added source type to `actions/code-injection/medium` such that now `github.head_ref` is found as source even on event `pull_request` (not just `pull_request_target`). This will result in the query finding more results. | |
| * Added a source type to `actions/code-injection/medium` so `github.head_ref` is now treated as a source on the `pull_request` event (not just `pull_request_target`). This will result in the query finding more results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since all the context event sources are considered by this query (regardless of trigger event) then context sources should also be, otherwise we get reporting inconsistency as follow:
vs
only made this change for the medium level query, since it does also make some sense to consider trigger event.