Merged
Conversation
angelapwen
previously approved these changes
Jan 5, 2023
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Thank you for this!!!! It's so much clearer now. And, I learned that we have AssertNever now
aeisenberg
reviewed
Jan 5, 2023
| variant: util.GitHubVariant, | ||
| logger: Logger | ||
| ): Promise<CodeQLToolsSource> { | ||
| if (toolsInput && toolsInput !== "latest" && !toolsInput.startsWith("http")) { |
Contributor
There was a problem hiding this comment.
Minor:
Suggested change
| if (toolsInput && toolsInput !== "latest" && !toolsInput.startsWith("http")) { | |
| if (toolsInput !== "latest" && !toolsInput?.startsWith("http")) { |
Contributor
Author
There was a problem hiding this comment.
I think that would start accepting toolsInput === undefined, which we don't want here.
src/codeql.ts
Outdated
| logger.debug("Downloading CodeQL bundle with token."); | ||
| headers.authorization = `token ${apiDetails.auth}`; | ||
| } else { | ||
| logger.debug("Downloading CodeQL bundle without token."); |
Contributor
There was a problem hiding this comment.
In this case, the URL may still have a token search param, Should we explicitly remove it?
Contributor
There was a problem hiding this comment.
Looks like this was always here, so maybe not a problem?
Contributor
Author
There was a problem hiding this comment.
"without adding token" would be more accurate — the goal here is to log that we aren't using the token input to init here.
aeisenberg
approved these changes
Jan 6, 2023
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how the Action sets up the CodeQL tools. The aim is to make the code more readable and to set the stage for improving how we roll out new CodeQL versions.
Merge / deployment checklist