Improve the robustness of creating and uploading debug artifacts#2486
Merged
henrymercer merged 5 commits intomainfrom Sep 17, 2024
Merged
Improve the robustness of creating and uploading debug artifacts#2486henrymercer merged 5 commits intomainfrom
henrymercer merged 5 commits intomainfrom
Conversation
aeisenberg
reviewed
Sep 16, 2024
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Just a jsdoc comment that can be improved. Otherwise, 👍🏼 .
Comment on lines
+69
to
+73
| /** | ||
| * Try to get the SARIF result path for the given language. | ||
| * | ||
| * If an error occurs, log it and return an empty list. | ||
| */ |
Contributor
There was a problem hiding this comment.
This comment and the function name are a little misleading because this function has a side effect that is not mentioned or implied.
Contributor
Author
There was a problem hiding this comment.
Good point, I'll get the PR in and address this as follow up.
angelapwen
approved these changes
Sep 16, 2024
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Also looks good to me! Makes sense, the original refactor dropped some of the error catching where the original debug artifact upload methods were called 👍
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tolerate failures when creating and uploading debug artifacts, and add a fallback such that if bundling the database with the CLI fails, we will fall back to creating a partial database bundle.
Also use a helper function to simplify the common pattern
wrapError(e).message.Merge / deployment checklist