Capture stderr from extracting Zstandard bundles#2514
Merged
henrymercer merged 3 commits intomainfrom Oct 2, 2024
Merged
Conversation
angelapwen
approved these changes
Oct 2, 2024
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Refactoring makes sense 👍 just a question!
Comment on lines
+102
to
+106
| if (!tarVersion) { | ||
| throw new Error( | ||
| "Could not determine tar version, which is required to extract a Zstandard archive.", | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Does throwing here prevent us from falling back on the gzip version?
Contributor
Author
There was a problem hiding this comment.
Good idea to double check this — this should indeed be covered by the fallback in setupCodeQLBundle.
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the standard toolcache API to decompress bundles, but when decompression fails, we only get the exit code from the toolcache API, which isn't very helpful for debugging.
Therefore this PR calls
tardirectly when decompressing Zstandard bundles to provide better quality failure information. A large part of the PR is a refactor to expose the functionality we use for invoking and capturing errors from the CLI in a generic way.Merge / deployment checklist