Python: Handle new default for standard library extraction#2536
Merged
yoff merged 4 commits intogithub:mainfrom Oct 11, 2024
Merged
Python: Handle new default for standard library extraction#2536yoff merged 4 commits intogithub:mainfrom
yoff merged 4 commits intogithub:mainfrom
Conversation
probably still need to route some values around
fcaf886 to
ce5f900
Compare
tausbn
approved these changes
Oct 10, 2024
tausbn
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
(However, I'm not familiar with most aspects of how codeql-action works, so we should probably get someone from the core team to give the go-ahead before merging.)
henrymercer
approved these changes
Oct 10, 2024
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
LGTM, both on the thinking and the code :)
This was referenced Oct 11, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you review this, could you also confirm my thinking on the following?
feature-flags.ts:Feature.CodeqlActionPythonDefaultIsToNotExtractStdlibwill be(come) true iff(((the feature flag is on AND NOT the disabling feature flag is on) OR the environment variable is set to true) AND NOT the environment variable is set to false) AND
ToolsFeature.PythonDefaultIsToNotExtractStdlibis true.x_disabled), and the environment variable. And the tools feature takes precedence, then the environment variable, then the disabling feature flag, then the feature flag."CODEQL_ACTION_DISABLE_PYTHON_STANDARD_LIBRARY_EXTRACTION"is now available to the action.src/tools-features.ts:ToolsFeature.PythonDefaultIsToNotExtractStdlibis now received from the CLI as long as the entry in there is calledpythonDefaultIsToNotExtractStdlibToolsFeature.PythonDefaultIsToNotExtractStdlibwill simply be off.Merge / deployment checklist