Conversation
Contributor
|
I think we need to update |
Macos-12 runners are deprecated and are refusing to run.
6a5586d to
bb7ad46
Compare
Contributor
Author
|
Since I removed some checks, the status won't be ready to merge until I update the checks. |
2cac9f7 to
b9d17bd
Compare
b9d17bd to
1489c9c
Compare
Contributor
Author
|
This was a lot trickier to get working that I was expecting. I think it should pass now. I will update the required checks afterwards. |
Contributor
|
#2588 fixes the export file baseline test. |
Contributor
Author
|
Rebasing in order to get a fix for |
henrymercer
approved these changes
Nov 8, 2024
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
LGTM. Thanks Andrew!
Contributor
Author
|
I can now update the required checks and get this merged. |
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macos-12 runners are deprecated and are refusing to run.
See some of the failures like this one: https://github.com/github/codeql-action/actions/runs/11671821941/job/32499094199?pr=2575