Improve Git subgraph fetching for diff-informed queries#2638
Merged
Conversation
This commit makes deepenGitHistory pass "origin HEAD" to Git fetch, which prevents Git from fetching all branches that are present in the remote repository.
This commits adds a "git repack" step to getPullRequestEditedDiffRanges to work around a Git bug concerning tracking of grafted commits.
henrymercer
approved these changes
Dec 10, 2024
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
This all looks sensible to me, assuming you've done the necessary manual testing. I'd like to see us add a PR check so we can validate this behaviour end to end, but that can be future work.
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how the action fetches the relevant Git subgraph used for computing the merge base with the base branch.
Merge / deployment checklist