Feature flag: C/C++ overlay by IdrissRio · Pull Request #3584 · github/codeql-action

IdrissRio · 2026-03-19T09:29:33Z

I'm not sure if this has to be filled in for this specific case. If the reviewer thinks it's useful/mandatory I'll be happy to do it.

Risk assessment

For internal use only. Please select the risk level of this change:

Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

Advanced setup - Impacts users who have custom CodeQL workflows.
Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
Code Quality - The changes impact analyses when analysis-kinds: code-quality.
Other first-party - The changes impact other first-party analyses.
Third-party analyses - The changes affect the upload-sarif action.

Environments:

Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
GHES - Impacts CodeQL workflows on GitHub Enterprise Server.
Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

Test repository - This change will be tested on a test repository before merging.
Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

Telemetry - I rely on existing telemetry or have made changes to the telemetry.
- Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
- Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

No special considerations - This change can be merged at any time.

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Consider adding a changelog entry for this change.
Confirm the readme and docs have been updated if necessary.

Copilot

Pull request overview

Adds C/C++ support gates for overlay analysis by introducing dedicated feature flags and a per-language minimum CodeQL CLI version, aligning overlay enablement with language-specific rollout control.

Changes:

Introduce CODEQL_OVERLAY_MINIMUM_VERSION_CPP (2.25.0) for overlay analysis.
Add C/C++ overlay analysis feature flags (general + code-scanning-only variants) with env-var overrides and minimum CLI version constraints.
Regenerate compiled lib/ outputs to reflect the TypeScript changes.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/overlay/index.ts	Adds the per-language minimum CLI version constant for C/C++ overlay analysis.
src/feature-flags.ts	Adds new C/C++ overlay feature flags and wires them into the feature flag configuration (env vars + minimum version).
lib/upload-sarif-action.js	Generated output reflecting the TypeScript changes.
lib/upload-sarif-action-post.js	Generated output reflecting the TypeScript changes.
lib/upload-lib.js	Generated output reflecting the TypeScript changes.
lib/start-proxy-action.js	Generated output reflecting the TypeScript changes.
lib/start-proxy-action-post.js	Generated output reflecting the TypeScript changes.
lib/setup-codeql-action.js	Generated output reflecting the TypeScript changes.
lib/resolve-environment-action.js	Generated output reflecting the TypeScript changes.
lib/init-action.js	Generated output reflecting the TypeScript changes.
lib/init-action-post.js	Generated output reflecting the TypeScript changes.
lib/autobuild-action.js	Generated output reflecting the TypeScript changes.
lib/analyze-action.js	Generated output reflecting the TypeScript changes.
lib/analyze-action-post.js	Generated output reflecting the TypeScript changes.

You can also share your feedback on Copilot code review. Take the survey.

src/feature-flags.ts

IdrissRio · 2026-03-19T12:11:18Z

src/feature-flags.ts

+  [Feature.OverlayAnalysisCpp]: {
+    defaultValue: false,
+    envVar: "CODEQL_ACTION_OVERLAY_ANALYSIS_CPP",
+    minimumVersion: CODEQL_OVERLAY_MINIMUM_VERSION_CPP,
+  },


I don't think this is necessary.

henrymercer

This looks good — two things before we merge:

We need to update the "No overlay analysis for language without per-language overlay feature flag" test to use a different language, perhaps Swift?
Could you add a changelog note? Something like "We are rolling out improved incremental analysis to C/C++ analyses that use build mode none. We expect this rollout to be complete by ___."?

Wire C/C++ overlay feature flags into overlay mapping

IdrissRio · 2026-03-19T13:42:13Z

Thanks @henrymercer! I addressed the comments here 0d057cc and 074a0db

CHANGELOG.md

Co-authored-by: Henry Mercer <henrymercer@github.com>

github-actions bot added the size/XS Should be very easy to review label Mar 19, 2026

IdrissRio force-pushed the idrissrio/cpp/overlay branch 2 times, most recently from d40f546 to 3486de8 Compare March 19, 2026 11:18

IdrissRio marked this pull request as ready for review March 19, 2026 11:44

IdrissRio requested a review from a team as a code owner March 19, 2026 11:44

Copilot AI review requested due to automatic review settings March 19, 2026 11:44

Copilot AI reviewed Mar 19, 2026

View reviewed changes

IdrissRio force-pushed the idrissrio/cpp/overlay branch from 52b3b10 to fb5dd8b Compare March 19, 2026 12:13

henrymercer reviewed Mar 19, 2026

View reviewed changes

IdrissRio added 5 commits March 19, 2026 14:10

Feature flag: C/C++ overlay

899a672

Feature flag: update generated lib after build

ce4a1fe

Feature flag: address copilot comment

ab3b6fd

Wire C/C++ overlay feature flags into overlay mapping

Feature flag: update test without overlay support

074a0db

Add changelog note for C/C++ overlay

0d057cc

IdrissRio force-pushed the idrissrio/cpp/overlay branch from 1334e5c to 0d057cc Compare March 19, 2026 13:12

henrymercer previously approved these changes Mar 19, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

e6d83bc

Co-authored-by: Henry Mercer <henrymercer@github.com>

IdrissRio dismissed henrymercer’s stale review via e6d83bc March 19, 2026 13:58

henrymercer previously approved these changes Mar 19, 2026

View reviewed changes

IdrissRio enabled auto-merge March 19, 2026 14:03

IdrissRio added this pull request to the merge queue Mar 19, 2026

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 19, 2026

Merge branch 'main' into idrissrio/cpp/overlay

39191bd

IdrissRio dismissed henrymercer’s stale review via 39191bd March 19, 2026 14:42

IdrissRio requested a review from henrymercer March 19, 2026 14:55

redsun82 approved these changes Mar 19, 2026

View reviewed changes

IdrissRio added this pull request to the merge queue Mar 19, 2026

Merged via the queue into main with commit 30c555a Mar 19, 2026
225 checks passed

IdrissRio deleted the idrissrio/cpp/overlay branch March 19, 2026 15:49

mahammadabdurahman497-arch mentioned this pull request Mar 19, 2026

Fix handling of non-string values from repository properties API #3557

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature flag: C/C++ overlay#3584

Feature flag: C/C++ overlay#3584
IdrissRio merged 7 commits intomainfrom
idrissrio/cpp/overlay

IdrissRio commented Mar 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

IdrissRio Mar 19, 2026

Uh oh!

henrymercer left a comment

Uh oh!

IdrissRio commented Mar 19, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

IdrissRio commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Risk assessment

Which use cases does this change impact?

How did/will you validate this change?

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

How will you know if something goes wrong after this change is released?

Are there any special considerations for merging or releasing this change?

Merge / deployment checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

IdrissRio Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

henrymercer left a comment

Choose a reason for hiding this comment

Uh oh!

IdrissRio commented Mar 19, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IdrissRio commented Mar 19, 2026 •

edited

Loading