Extend start-proxy.yml to test multiple registry support#3792
Merged
Conversation
For the sake of consistency with the other pre-existing validation code.
Member
|
@mario-campos You need to re-generate the actual workflow files from the updated template by running |
The registry/language mapping table does not map the one with hyphens.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the start-proxy pr-check to exercise “multiple registries of the same type” by configuring two Maven registries and asserting that the action’s proxy_urls output contains both entries.
Changes:
- Switch
registry_secretsin the start-proxy pr-check from a single NuGet registry to two Maven registries. - Add a workflow assertion intended to verify
proxy_urlsincludes both configured registries. - Regenerate the corresponding
__start-proxy.ymlworkflow to reflect the pr-check template change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pr-checks/checks/start-proxy.yml | Expands the start-proxy test to configure multiple Maven registries and adds validation of proxy_urls. |
| .github/workflows/__start-proxy.yml | Generated workflow updated to match the pr-check template change. |
mbg
previously approved these changes
Mar 31, 2026
Member
mbg
left a comment
There was a problem hiding this comment.
LGTM, thanks for improving the step name!
mbg
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
How did/will you validate this change?
pr-checks).jqcommand was manually tested to ensure that it behaves as expected.If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist