Merged
Conversation
Contributor
Author
|
Sorry this PR may not make much sense. To review I think it's best to know that these inputs are used by the code to send status reports, and this is called from all actions. Then look at the |
sampart
approved these changes
Jun 16, 2020
Contributor
sampart
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the delay in reviewing this.
Contributor
Author
|
1 fixed alert. Excellent. That's what I expected |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this input is missing. It is used to construct the status reports.
Not sure how this is missing, especially as we have a query for it. Though to be fair we haven't gone through to eliminate all the cases of that as they are actually pretty benign in practice.
Merge / deployment checklist