Conversation
06ce9a0 to
6dcaced
Compare
6dcaced to
052d39e
Compare
robertbrignull
approved these changes
Jun 23, 2020
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
So long as the indentation is enforced by tslint, and therefore by the PR checks, then I'm happy. It looks like that is the case.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like we've ended up with a bit of a mixture of 2 and 4 space indentation in the codebase. After some discussion it seems like no one really minds which we use, so long as it's consistent. I've ended up picking two-space indentation since that seems to be the community preference.
I've added an editorconfig file which many editors will use to automatically determine the indentation style of new files.
I've also replaced the TSLint
indentrule (which is broken) with ter-indent from the tslint-eslint-rules package. Ideally we should switch entirely from TSLint to ESLint, but it seems best to do that in a follow-up pull request.Merge / deployment checklist