Only output anything from tests when there's a failure#79
Merged
robertbrignull merged 12 commits intomainfrom Jun 24, 2020
Merged
Only output anything from tests when there's a failure#79robertbrignull merged 12 commits intomainfrom
robertbrignull merged 12 commits intomainfrom
Conversation
4 tasks
sampart
approved these changes
Jun 23, 2020
Contributor
sampart
left a comment
There was a problem hiding this comment.
Oh my goodness, this is SUCH a big step on from what I did. Love it! Just one comment.
robertbrignull
commented
Jun 24, 2020
| }; | ||
| } | ||
|
|
||
| export function silenceDebugOutput(test: TestInterface<any>) { |
Contributor
Author
There was a problem hiding this comment.
In hindsight, should perhaps rename this to something else. I'll open a new PR for that.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative / builds upon #75
The extra bits are:
typedTest.afterEach.alwaysinstead oftypedTest.afterEachbecause the latter only runs on passing tests.Merge / deployment checklist