Safely transliterate international characters for aliases#181
Hidden character warning
Safely transliterate international characters for aliases#181mislav merged 1 commit intogithub:masterfrom PurpleBooth:piñata-to-pinata
Conversation
|
This is failing because of lack of support of end of life ruby versions before 2.3 from the i18n library (2.2. was EOL more than 2 years ago now, so not an unreasonable policy). I can probably fix this, but it'll be a less than ideal solution. Give me a shout if you'd like to continue maintaining support for the older versions, and I'll see what I can do. |
koddsson
left a comment
There was a problem hiding this comment.
This is failing because of lack of support of end of life ruby versions before 2.3 from the i18n library (2.2. was EOL more than 2 years ago now, so not an unreasonable policy).
I think it's reasonable to not support ruby versions < 2.3 given that they are all EOL. Interested in hearing what @mislav thinks.
mislav
left a comment
There was a problem hiding this comment.
This is great! Thank you for fixing this 🙇
Currently when we encounter an international character (from the perspective of someone in the USA, or UK), we replace it with an underscore (_)
This isn't ideal because it means words like piñata become pi_ata. There's a good way to transliterate these characters into their ASCII character range representation using the i18n library.
This will take the excellent detective work done by @stone-zeng and use that to create a fix.
Relates to: #180