Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Use push helpers to format Talker messages#222

Merged
technoweenie merged 1 commit intogithub:masterfrom
Mange:patch-1
Jan 13, 2012
Merged

Use push helpers to format Talker messages#222
technoweenie merged 1 commit intogithub:masterfrom
Mange:patch-1

Conversation

@Mange
Copy link
Contributor

@Mange Mange commented Jan 13, 2012

This correctly shows the actual pusher when a push happens instead of
whomever committed the last commit. It will also make the message a tad
more interesting:

Joe Pusher created some-branch from master (+2 new commits)

instead of

Mary Committer pushed 2 commits

Tests continues to pass on 1.8.7. Get syntax error when trying to run with 1.9.2.

This correctly shows the actual pusher when a push happens instead of
whomever committed the last commit. It will also make the message a tad
more interesting:

  Joe Pusher created some-branch from master (+2 new commits)

instead of

  Mary Committer pushed 2 commits
technoweenie added a commit that referenced this pull request Jan 13, 2012
Use push helpers to format Talker messages
@technoweenie technoweenie merged commit fe24aac into github:master Jan 13, 2012
@jrom
Copy link
Contributor

jrom commented Jan 13, 2012

Why you remove the link? :(

@Mange
Copy link
Contributor Author

Mange commented Jan 13, 2012

@jrom Sorry, that was a mistake. It should be trivial to add

@chuyeow
Copy link

chuyeow commented Jan 20, 2012

@technoweenie Can you check pull request #224? It's rather annoying and useless without the URL :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants