Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Fix dependencies to allow publish#452

Merged
hendrikvanantwerpen merged 2 commits intomainfrom
remve-npm-action
Jul 10, 2024
Merged

Fix dependencies to allow publish#452
hendrikvanantwerpen merged 2 commits intomainfrom
remve-npm-action

Conversation

@hendrikvanantwerpen
Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen commented Jul 10, 2024

The previous PR removed explicit versions for in-repo dependencies. I expected that cargo publish would just replace the path dependency with the current version, but instead it complains and aborts.

This PR restores the version numbers where required. (It seems not required for dev dependencies, which I verified using a local cargo publish --dry-run.)

I also removed the publish-npm workflow job, which would have failed since the NPM package has been removed.

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner July 10, 2024 15:21
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Jul 10, 2024
@hendrikvanantwerpen hendrikvanantwerpen merged commit 627e93c into main Jul 10, 2024
@hendrikvanantwerpen hendrikvanantwerpen deleted the remve-npm-action branch July 10, 2024 15:29
@github-actions
Copy link

github-actions bot commented Jul 10, 2024

Performance Summary

Comparing base f715ed1 with head 9649181 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before 
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.275^                                                   #                    
     |                                                   #                    
     |                                                  :#                    
     |                                               @@@:#                    
     |                                               @  :#                    
     |                                               @  :#                    
     |                                             ::@  :#                ::::
     |                                            :: @  :#                :: :
     |                                            :: @  :#                :: :
     |                                     @@  ::::: @  :#       ::   :::::: :
     |                     @@  @@         :@@: :: :: @  :#      ::: : ::  :: :
     |                     @@::@@: ::    ::@@:::: :: @  :#     ::::@::::  :: :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   87.72
After 
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.275^                                                  #                     
     |                                                  #                     
     |                                                 :#                     
     |                                              @@@:#                     
     |                                              @  :#                  :::
     |                                              @  :#                  : :
     |                                            ::@  :#                ::: :
     |                                           :: @  :#                : : :
     |                                           :: @  :#                : : :
     |                                     @  ::::: @  :#       ::  :::::: : :
     |                         :         ::@ ::: :: @  :#      ::: :::   : : :
     |                    @::::: : ::   :::@:::: :: @  :#     ::::@:::   : : :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   89.70

@github github deleted a comment from Tkinfolks Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@patrickt patrickt patrickt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hendrikvanantwerpen hendrikvanantwerpen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hendrikvanantwerpen @patrickt