FEATURE: MSF-22857 Sub module gooddata_brick_base to import in bricks#1849
Merged
1 commit merged intogooddata:masterfrom Apr 19, 2022
Merged
FEATURE: MSF-22857 Sub module gooddata_brick_base to import in bricks#18491 commit merged intogooddata:masterfrom
1 commit merged intogooddata:masterfrom
Conversation
|
Build succeeded (check pipeline). |
Contributor
Author
|
ok to test |
|
Build succeeded (check pipeline). |
Contributor
Author
|
ok to test |
|
Build failed (check pipeline). |
425bb3c to
d06e260
Compare
|
Build succeeded (check pipeline). |
d06e260 to
c8a0eb3
Compare
|
Build succeeded (check pipeline). |
52a61d3 to
64f89c3
Compare
|
Build in pipeline check aborted. |
|
Build succeeded (check pipeline). |
sangtm
reviewed
Apr 15, 2022
lib/gooddata/bricks/pipeline_base.rb
Outdated
|
|
||
| module GoodData | ||
| module Bricks | ||
| class PipelineBase |
There was a problem hiding this comment.
Change to BasePipeline for consitence, change file name also please.
Contributor
Author
There was a problem hiding this comment.
Done update code. Thank you.
64f89c3 to
c5b779b
Compare
|
Build succeeded (check pipeline). |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ruby-gate-PR1849 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
|
Build succeeded (gate pipeline).
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.