Remove ADK dependency for langchain4j module #725
Conversation
Summary of ChangesHello @gbrail, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the google-adk-dev dependency from the langchain4j module. This is an excellent change that correctly identifies and removes an unnecessary dependency, which in turn prevents pulling in heavy transitive dependencies like Spring Boot for consumers of the langchain4j module. This improves the module's isolation and makes it more lightweight for integration into other projects. The change is approved.
The langchain4j module in the "contrib" directory depends on adk-dev, although it doesn't seem to need anything in that module. This, in turn, pulls in tons of stuff for applications that use it, including logback and Spring Boot, which I'd like to not have to include in my project. This PR just takes the dependency out.