Fix #2723: Retry on HTTP 400 failedPrecondition#2730
Fix #2723: Retry on HTTP 400 failedPrecondition#2730codeXsidd wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the client's robustness by introducing automatic retry capabilities for specific HTTP 400 "Bad Request" errors. Previously, retries were primarily handled for certain 403 "Forbidden" errors. This change specifically targets Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request correctly adds retry logic for HTTP 400 errors with the failedPrecondition reason, which is a useful enhancement for handling transient errors. The implementation is sound and is accompanied by a new unit test that verifies the new behavior. I have one suggestion to refactor the retry condition logic to make it more data-driven and easier to extend in the future.
| if resp_status == http_client.FORBIDDEN: | ||
| LOGGER.warning('Encountered 403 Forbidden with reason "%s"', reason) | ||
| # Only retry on rate limit related failures. | ||
| if reason in ("userRateLimitExceeded", "rateLimitExceeded"): | ||
| return True | ||
| elif resp_status == http_client.BAD_REQUEST: | ||
| LOGGER.warning('Encountered 400 Bad Request with reason "%s"', reason) | ||
| # Only retry on precondition failures. | ||
| if reason in ("failedPrecondition", "preconditionFailed"): | ||
| return True |
There was a problem hiding this comment.
This if/elif block for handling retryable reasons can be refactored to be more data-driven. Using a dictionary to map status codes to their retryable reasons would make this logic more concise and easier to extend with new status codes or reasons in the future.
| if resp_status == http_client.FORBIDDEN: | |
| LOGGER.warning('Encountered 403 Forbidden with reason "%s"', reason) | |
| # Only retry on rate limit related failures. | |
| if reason in ("userRateLimitExceeded", "rateLimitExceeded"): | |
| return True | |
| elif resp_status == http_client.BAD_REQUEST: | |
| LOGGER.warning('Encountered 400 Bad Request with reason "%s"', reason) | |
| # Only retry on precondition failures. | |
| if reason in ("failedPrecondition", "preconditionFailed"): | |
| return True | |
| RETRYABLE_REASONS = { | |
| http_client.FORBIDDEN: ( | |
| {'userRateLimitExceeded', 'rateLimitExceeded'}, | |
| 'Encountered 403 Forbidden with reason "%s"', | |
| ), | |
| http_client.BAD_REQUEST: ( | |
| {'failedPrecondition', 'preconditionFailed'}, | |
| 'Encountered 400 Bad Request with reason "%s"', | |
| ), | |
| } | |
| if resp_status in RETRYABLE_REASONS: | |
| reasons, log_message = RETRYABLE_REASONS[resp_status] | |
| if reason in reasons: | |
| LOGGER.warning(log_message, reason) | |
| return True |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕