Skip to content

feat: [dataplex] new module for dataplex#12342

Open
cloud-java-bot wants to merge 1 commit intomainfrom
new-library/dataplex-SbkTt
Open

feat: [dataplex] new module for dataplex#12342
cloud-java-bot wants to merge 1 commit intomainfrom
new-library/dataplex-SbkTt

Conversation

@cloud-java-bot
Copy link
Copy Markdown
Collaborator

Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-library --api-shortname "dataplex" --name-pretty "Cloud Dataplex API" --api-description "Dataplex Universal Catalog is an intelligent data governance solution that helps you unify and manage distributed data at scale, with lower operational overhead." --proto-path "google/cloud/dataplex/v1" --product-docs "https://cloud.google.com/dataplex/docs/overview" 

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner March 31, 2026 21:23
@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily reformats generation_config.yaml by moving documentation URLs to new lines and updating string quoting for several API descriptions. A critical issue was identified regarding the addition of a duplicate dataplex library definition, which could lead to configuration conflicts.

Comment on lines +846 to +862
- api_shortname: dataplex
name_pretty: Cloud Dataplex API
product_documentation: https://cloud.google.com/dataplex/docs/overview
api_description: Dataplex Universal Catalog is an intelligent data governance solution
that helps you unify and manage distributed data at scale, with lower operational
overhead.
client_documentation:
https://cloud.google.com/java/docs/reference/google-cloud-dataplex/latest/overview
release_level: preview
distribution_name: com.google.cloud:google-cloud-dataplex
api_id: dataplex.googleapis.com
library_type: GAPIC_AUTO
group_id: com.google.cloud
cloud_api: true
GAPICs:
- proto_path: google/cloud/dataplex/v1
requires_billing: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a duplicate library definition for dataplex. An entry for api_shortname: dataplex already exists just before this new block (ending on line 845). Having two definitions for the same API will likely cause issues in the generation process. Please remove this duplicate entry. If the intention was to update the existing dataplex configuration, please modify the existing block instead of adding a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owlbot:run Add this label to trigger the Owlbot post processor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant